Fixed RPM SPEC file Changelog not being read issue #236
Conversation
jyo64
changed the title
| @@ -105,6 +105,10 @@ class MakeRPMConfig extends MakeConfig { | |||
|
|
|||
| @override | |||
| Map<String, dynamic> toJson() { | |||
| final currentDate = DateTime.now(); | |||
| DateTime now = DateTime.now(); | |||
There was a problem hiding this comment.
Possibly unnecessary duplicate variable? You could just use currentDate
There was a problem hiding this comment.
(or now even simpler :-) )
As for the cp error, it seems it just needs the ../ relative path adding to the cp commands; so that ll131-143 would read
'%install': [
'mkdir -p %{buildroot}%{_bindir}',
'mkdir -p %{buildroot}%{_datadir}/%{name}',
'mkdir -p %{buildroot}%{_datadir}/applications',
'mkdir -p %{buildroot}%{_datadir}/metainfo',
'mkdir -p %{buildroot}%{_datadir}/pixmaps',
'cp -r ../%{name}/* %{buildroot}%{_datadir}/%{name}',
'ln -s %{_datadir}/%{name}/%{name} %{buildroot}%{_bindir}/%{name}',
'cp -r ../%{name}.desktop %{buildroot}%{_datadir}/applications',
'cp -r ../%{name}.png %{buildroot}%{_datadir}/pixmaps',
'cp -r ../%{name}*.xml %{buildroot}%{_datadir}/metainfo || :',
'update-mime-database %{_datadir}/mime &> /dev/null || :',
'%undefine __brp_add_determinism',
].join('\n'),
(including the %undefine that hangs); maybe you could please test whether that is a complete resolution of the regression for you as it seems it is for me?
|
Well done for spotting the cause of the error, it had been throwing warnings for a while; now that I upgraded to F41 it's a solid error. One question please, how to modify the behavior of (config at to the |
… from intial PR
|
Hi @MarkieMark Thanks for reviewing the code. I have now removed the duplicate variable you mentioned. Unfortunately my env is not currently setup and I'm busy with some academic stuff. Maybe you could test it and let me know if some changes are needed? The way I tested is with the following steps: First run
This will pull the flutter_distributor from the Original Git Repo Then I copy and paste the required modification in the global flutter packages directory And activate it again. Unfortunately I forgot the exact comment. One of those pulls the code from Github main again and overwrites and other reactivates the flutter package with the current modifications. I think its
But I'm not sure. Sorry my answer is vague. |
|
Unfortunately this still did not work for me due to some other issue with the copy command in the rpm packaging and I had to end up building the RPM manually. |
|
The while adding a relative path in basically works (may need |
|
alright that particular error I added a cd command to the . it's the %undefine to address the fact that it would hang at it then leaves the |
|
Happy to know you got it working 😀 |
The Date from build was not getting recorded properly in the SPEC file for RPM packaging due to the change log not being read and formatted properly. I have now fixed it. This solves #235.